Dev/gov qa round 1 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying staking-mainnet with
|
| Latest commit: |
67f692f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f9753a7b.staking-mainnet-8sr.pages.dev |
| Branch Preview URL: | https://dev-gov-qa-round-1.staking-mainnet-8sr.pages.dev |
Deploying staking-testnet with
|
| Latest commit: |
67f692f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b03c1c05.staking-testnet.pages.dev |
| Branch Preview URL: | https://dev-gov-qa-round-1.staking-testnet.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA Issues
Remediation
User vote value must show in overview component
Vote values queried from the vote API differed from vote_tally. This was remedied as well as a typo bug, a missing
$sign in the component renderer.Disable vote buttons if user is logged out
Check login state and render accordingly. Add text to inform user why voting is disabled (logout vs. voting period).
Handle Errors better. "Out of Gas"
The "out of gas" error was an internal bug due to a hard value set in the staking logic which was used for governance. This has been updated to properly query for a successful transaction. If there is an error, it will render in the tx state modal.
Tx state feedback/refresh query on tx complete
Related to the previous issue, modal state now awaits Tx verification with distinct codes for the transaction state: confirmation, pending, success, and error. The user must now click the modal when the tx is completed and will see that the vote value has been updated.
* Quorum not properly rendering progress
The quorum component was not appropriately showing the progress of vote totals to achieve quorum. Added info to tooltip to better explain.